linux-kernel - Re: [PATCH] synclink drivers bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47D5A793.9070105@microgate.com>
Date:	Mon, 10 Mar 2008 15:26:43 -0600
From:	Paul Fulghum <paulkf@...rogate.com>
To:	Joe Perches <joe@...ches.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] synclink drivers bool conversion

Joe Perches wrote:
> On Sun, 2008-03-09 at 12:49 -0700, Joe Perches wrote:
>> diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c
>> index ddc74d1..abf3c37 100644
>> --- a/drivers/char/synclink.c
>> +++ b/drivers/char/synclink.c
>> @@ -5413,9 +5410,9 @@ static void usc_process_rxoverrun_sync( struct mgsl_struct *info )
>>  
>>  		if ( !start_of_frame_found )
>>  		{
>> -			start_of_frame_found = TRUE;
>> +			start_of_frame_found = true;
>>  			frame_start_index = end_index;
>> -			end_of_frame_found = FALSE;
>> +			end_of_frame_found = true;
>>  		}
>>  
>>  		if ( buffer_list[end_index].status )
> 
> end_of_frame_found should be false

OK the patch checks out (with the above fix).

Post the updated patch with a CC to Andrew
and I'll post an Acked-by response.

-- 
Paul Fulghum
Microgate Systems, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/