linux-kernel - Re: [PATCH] tty_ioctl: locking for tty_wait_until

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080310220643.60f36bee@core>
Date:	Mon, 10 Mar 2008 22:06:43 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty_ioctl: locking for tty_wait_until_sent

On 10 Mar 2008 23:12:51 +0100
Andi Kleen <andi@...stfloor.org> wrote:

> Alan Cox <alan@...rguk.ukuu.org.uk> writes:
> 
> > This function still depends on the big kernel lock in some cases. Push
> > locking into the function ready for removal of the BKL from ioctl call
> > paths.
> 
> Didn't you forget the .ioctl -> .unlocked_ioctl change?

We are not yet ready to unlock the device ioctl paths for tty. We still
explicitly take the BKL in the ioctl paths when calling the following
methods

driver:
	->wait_until_sent()
	->break_ctl()
	->tiocmget
	->tiocmset
	->ioctl
ldisc:
	->ioctl

As well as all the open/close/hangup/ldisc change logic

I'm pretty close to removing it from the modem , ioctl and break methods
and its working for me but needs a few drivers tweaking further.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/