linux-kernel - Re: [PATCH 2/2] cgroup: switch to proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47D5C796.1080302@cn.fujitsu.com>
Date:	Tue, 11 Mar 2008 08:43:18 +0900
From:	Li Zefan <lizf@...fujitsu.com>
To:	Paul Menage <menage@...gle.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] cgroup: switch to proc_create()

Paul Menage wrote:
> On Mon, Mar 10, 2008 at 12:30 AM, Li Zefan <lizf@...fujitsu.com> wrote:
>> There is a race between create_proc_entry() and the assignment
>>  of file ops. proc_create() is invented to fix it.
>>
>>  Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> 
> Acked-by: Paul Menage <menage@...gle.com>
> 
> Doesn't seem to be a serious race since there's nothing in userspace
> at this point to read the file. But replacing four lines with one is
> generally a good thing.
> 

Yes I know, it's a slight race in case of modular code, but the aim is 
to replace all the use of create_proc_entry() with proc_create(). :) 

> Paul
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/