linux-kernel - Re: [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47D5D7BB.1070206@pobox.com>
Date:	Mon, 10 Mar 2008 20:52:11 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Roel Kluin <12o3l@...cali.nl>
CC:	linux-ide@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ATA: logical-bitwise and confusion in ahci_save_initial_config()

Roel Kluin wrote:
> logical-bitwise & confusion
> 
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 8a49835..1b73307 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -672,7 +672,7 @@ static void ahci_save_initial_config(struct pci_dev *pdev,
>  		cap &= ~HOST_CAP_NCQ;
>  	}
>  
> -	if ((cap && HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
> +	if ((cap & HOST_CAP_PMP) && (hpriv->flags & AHCI_HFLAG_NO_PMP)) {
>  		dev_printk(KERN_INFO, &pdev->dev,
>  			   "controller can't do PMP, turning off CAP_PMP\n");
>  		cap &= ~HOST_CAP_PMP;

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/