linux-kernel - Re: [PATCH] [6/13] Core maskable allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080311155445.GB27593@one.firstfloor.org>
Date:	Tue, 11 Mar 2008 16:54:45 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jonathan Corbet <corbet@....net>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH] [6/13] Core maskable allocator

On Tue, Mar 11, 2008 at 09:34:53AM -0600, Jonathan Corbet wrote:
> Hi, Andi,
> 
> As I dig through this patch, I find it mostly makes sense; seems like it
> could be a good idea. 

Thanks.
> 
> > +struct page *
> > +alloc_pages_mask(gfp_t gfp, unsigned size, u64 mask)
> > +{
> > +	unsigned long max_pfn = mask >> PAGE_SHIFT;
> 
> The "mask" parameter isn't really a mask - it's an upper bound on the

Actually it's both.

> address of the allocated memory.  Might it be better to call it
> "max_addr" or "limit" or "ceiling" or some such so callers understand

mask is the standard term used by the PCI-DMA API for the same
thing and since one of the main purposes of the mask allocator is to 
implement underlying support for that interface it seemed fitting to use 
the same convention.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/