linux-kernel - Re: mpparse_{32,64}.c merge questions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200803111328.43314.lenb@kernel.org>
Date:	Tue, 11 Mar 2008 13:28:43 -0400
From:	Len Brown <lenb@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Cc:	Alexey Starikovskiy <astarikovskiy@...e.de>,
	Andi Kleen <ak@...e.de>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: mpparse_{32,64}.c merge questions

On Tuesday 04 March 2008, Ingo Molnar wrote:
> 
> (more folks Cc:-ed)
> 
> * Alexey Starikovskiy <astarikovskiy@...e.de> wrote:
> 
> >>> I've decided to start with merge of mpparse files, and I'd like to 
> >>> know your opinion on some differences... Ingo, I know you work on 
> >>> merging the 32/64 files, do I step on your toes?
> >>
> >> My suggestion would be to do a redesign first and then do that for 
> >> both.
> > I was thinking that redesign on one file would go easier... And we 
> > don't need both, do we?
> 
> we dont, but please do _not_ "redesign" anything during unification.
> 
> try to keep it simple and bisectable. Lots of small patches. Stupid
> #ifdefs if need to be. Pick the 32-bit version or the 64-bit version of
> any approach, if it's obvious that the unified version will still work 
> fine. Ask if in doubt.


I agree with Ingo on the "keep it simple" merge steps..

I can't resist mentioning, however, what I'd like to see long term.

I'd like to see mpparse.o depend on CONFIG_MPS=y
I'd like to be able to build CONFIG_ACPI=y and CONFIG_MPS=n

Andy Grover prototyped splititing MPS from ACPI a while back,
but it never made it upstream.

thanks,
-Len
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/