linux-kernel - Re: [PATCH 5/6] signals: unify send_sigqueue/send_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080311181127.GC586@tv-sign.ru>
Date:	Tue, 11 Mar 2008 21:11:27 +0300
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Roland McGrath <roland@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Pavel Emelyanov <xemul@...nvz.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] signals: unify send_sigqueue/send_group_sigqueue completely

On 03/10, Roland McGrath wrote:
>
> Looks fine.  But I'd like a comment on the "ret = 1" case making
> explicit what that magic return case is for and why the value
> matters (to posix_timer_event).

Well, currently this helper is solely used by posix_timer_event(), but despite
the fact it has BUG_ON(!SI_TIMER) it is quite generic, there were patches which
used it for aio.

So I don't think we should document the interaction with posix timers, but OK,
I'll send a small comment update.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/