linux-kernel - Re: [PATCH 2.6.24] mm: BadRAM support for broken memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <873aqxqd1c.fsf@saeurebad.de>
Date:	Tue, 11 Mar 2008 20:24:47 +0100
From:	Johannes Weiner <hannes@...urebad.de>
To:	Jan-Simon Möller <dl9pf@....de>
Cc:	Len Brown <lenb@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Pavel Machek <pavel@....cz>, Jiri Kosina <jkosina@...e.cz>,
	Ingo Molnar <mingo@...e.hu>, devzero@....de,
	linux-kernel@...r.kernel.org, rick@...rein.org
Subject: Re: [PATCH 2.6.24] mm: BadRAM support for broken memory

Hi Jan-Simon,

Jan-Simon Möller <dl9pf@....de> writes:

> Patches V3 with corrected Syntax, tnx hpa !
> Changed also text according to idea from Len.
>
> diff --git a/Documentation/kernel-parameters.txt 
> b/Documentation/kernel-parameters.txt
> index 533e67f..f25da88 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -1131,6 +1131,10 @@ and is between 256 and 4096 characters. It is defined 
> in the file
>         memmap=nn[KMG]$ss[KMG]
>                         [KNL,ACPI] Mark specific memory as reserved.
>                         Region of memory to be used, from ss to ss+nn.
> +                       Example: Exclude memory from 0x18690000-0x1869ffff
> +                                memmap=64K$0x18690000
> +                                or
> +                                memmap=0x10000$0x18690000
>
>         meye.*=         [HW] Set MotionEye Camera parameters
>                         See Documentation/video4linux/meye.txt.
>
>
> Signed-off-by: Jan-Simon Moeller <dl9pf@....de>

Would you mind formatting the patch as described in
Documentation/SubmittingPatches?  That probably increases the chance of
getting it merged.

As far as your patch is concerned, I see broken whitespace, a changelog
entry and the signed-off-by is in the wrong place.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/