linux-kernel - Re: [PATCH] Terminate hugetlbfs mount argument list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080311225623.GE428@one.firstfloor.org>
Date:	Tue, 11 Mar 2008 23:56:23 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Andi Kleen <andi@...stfloor.org>, akpm@...l.org,
	wli@...omorphy.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Terminate hugetlbfs mount argument list

On Tue, Mar 11, 2008 at 03:48:46PM -0700, Roland Dreier wrote:
>  > The match_table_t for the mount arguments in hugetlbfs wasn't 
>  > terminated as match_tokens expect. I didn't see a crash just code
>  > audit, but it's still safer to terminate it in case the variables after
>  > that in .data are not NULL.
> 
> I think you're misunderstanding the match_token() interface.  The
> comment before match_token() says:

Hmm indeed I did. To my defense it's a weird unusual coding pattern
that tricked me.  What good is it to give terminator elements own enum values?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/