linux-kernel - Re: [PATCH 8/6] signals: send_signal: factor out SIGNAL_GROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080311021633.BF1B326F991@magilla.localdomain>
Date:	Mon, 10 Mar 2008 19:16:33 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Pavel Emelyanov <xemul@...nvz.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/6] signals: send_signal: factor out SIGNAL_GROUP_EXIT checks

I think your logic is sound.  But for paranoia's sake I would add
a BUG_ON(signal->flags & SIGNAL_GROUP_EXIT) in the group-fatal case.

I don't really like dropping the signal on the floor.  If the posting says
it succeeded (vs -ESRCH) then I'd like to see it appear later in the
pending set of the zombie thread, when we look at /proc/pid/status at exit
tracing or whatnot (and in core dumps).  Seeing those pending signal bits
is sometimes a useful clue about how something died in a strange scenario.

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/