| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200803121451.23925.bzolnier@gmail.com> Date: Wed, 12 Mar 2008 14:51:23 +0100 From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> To: petkovbb@...il.com Cc: linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org Subject: Re: [PATCH 4/4] ide-tape: remove pipeline-specific code from idetape_add_chrdev_read_request() Hi, On Wednesday 12 March 2008, Borislav Petkov wrote: [...] > > > the read request's buffer directly thru idetape_queue_rw_tail() > > > > > > 3. Do next request buffer allocation (tape->merge_stage) > > > > Isn't idetape_init_read() taking care of 3.? > > i wanted to have the whole handling at one place and let _init_read() only > prepare the read. Now we don't allocate any new tape->merge_stage anymore, > which is wrong. Originally, this happened in _init_read(), however, if we do > idetape_queue_rw_tail(), we should alloc the new stage _after_ queueing the The original driver doesn't do this - it just calls idetape_queue_rw_tail(), could it be a bug in the original driver? [ ditto for idetape_queue_rw_tail() for writes ] > request, which means it cannot happen _init_read() now and should take place > afterwards, i.e. as it was in the original patch, or? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists