linux-kernel - Re: [PATCH] tty_ioctl: Soft carrier handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080312132210.42327363@the-village.bc.nu>
Date:	Wed, 12 Mar 2008 13:22:10 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty_ioctl: Soft carrier handling


> > +	int bit = arg ? CLOCAL : 0;
> > +	struct ktermios old = *tty->termios;
> 
> Maybe a dumb question, but shouldn't be the snapshot done in the critical 
> section too?

Yes it should. I'll fix that in the next bits and double check the cases
Andrew asks about (although I think they are ok with caller locking from
memory)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/