| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Mar 2008 15:31:58 +0100 From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> To: petkovbb@...il.com Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/4] ide-tape: remove pipeline-specific code from idetape_add_chrdev_write_request On Wednesday 12 March 2008, Borislav Petkov wrote: > > > The remaining pipeline stage allocation code is used for the next current > > > pipeline stage (tape->merge_stage) and data buffer for an upcoming > > > request. The so allocated pipeline stage is rewired into the tape struct > > > thru idetape_switch_buffers() and used during the next request for > > > copying user data into it (see e.g. idetape_chrdev_write()). In case the > > > allocation fails, the current request is still attempted prior to failing. > > > > Is this really needed now that we've removed pipeline operation for write > > requests? > > I did this simply to keep behavior changes at minimum - after removing the > pipeline code completely this'll be simplified too. BTW I see now how poorly I explained things the last time. :( [ Sorry for that! ] Our goal is not "pure" minimal behavior changes but minimal "behavior + code" changes - IOW we are searching for the best balance for keeping both the old behavior and code changes (and thus patch _complexity_) at the minimal level. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists