linux-kernel - Re: [PATCH] Mark early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47D7E6DB.6030709@zytor.com>
Date:	Wed, 12 Mar 2008 15:21:15 +0100
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	mingo@...hat.com, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] Mark early_printk as asmlinkage

Jiri Slaby wrote:
> On 03/12/2008 03:04 PM, H. Peter Anvin wrote:
>> Jiri Slaby wrote:
>>> It's not explicitly marked as asmlinkage, but invoked from x86_32
>>> startup code with parameters on stack.
>>>
>>> No other architectures define early_printk and none of them are affected
>>> by this change, since defines asmlinkage as empty token.
>>
>> NAK.
>>
>> The regparm ABI for x86-32 uses parameters on the stack when the 
>> function is varadic (as it is here), so this is unnecessary.
> 
> Makes sense. Why is printk marked as asmlinkage?

Hm.  Don't know if it's historical, stylistic (anything called from 
assembly should have "asmlinkage"), or just based on a misunderstanding 
of the regparm ABI.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/