linux-kernel - Re: [PATCH] signals: send_signal: be paranoid about signalfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0803120934360.30443@alien.or.mcafeemobile.com>
Date:	Wed, 12 Mar 2008 09:35:43 -0700 (PDT)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Oleg Nesterov <oleg@...sign.ru>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] signals: send_signal: be paranoid about signalfd_notify()

On Wed, 12 Mar 2008, Oleg Nesterov wrote:

> send_signal() shouldn't call signalfd_notify() if it then fails with -EAGAIN.
> Harmless, just a paranoid cleanup.
> 
> Also remove the comment. It is obsolete, signalfd_notify() was simplified and
> does a simple wakeup.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

Looks fine to me.

Acked-by: Davide Libenzi <davidel@...ilserver.org>



> 
> --- 25/kernel/signal.c~3_SS_NOTIFY	2008-03-12 15:16:52.000000000 +0300
> +++ 25/kernel/signal.c	2008-03-12 15:55:47.000000000 +0300
> @@ -769,13 +769,6 @@ static int send_signal(int sig, struct s
>  	 */
>  	if (legacy_queue(pending, sig))
>  		return 0;
> -
> -	/*
> -	 * Deliver the signal to listening signalfds. This must be called
> -	 * with the sighand lock held.
> -	 */
> -	signalfd_notify(t, sig);
> -
>  	/*
>  	 * fast-pathed signals for kernel-internal things like SIGSTOP
>  	 * or SIGKILL.
> @@ -825,6 +818,7 @@ static int send_signal(int sig, struct s
>  	}
>  
>  out_set:
> +	signalfd_notify(t, sig);
>  	sigaddset(&pending->signal, sig);
>  	complete_signal(sig, t, group);
>  	return 0;
> 


- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/