linux-kernel - Re: [patch 6/6] Guest page hinting: s390 support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47D8085E.9030701@goop.org>
Date:	Wed, 12 Mar 2008 09:44:14 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	schwidefsky@...ibm.com
CC:	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	virtualization@...ts.osdl.org, akpm@...l.org,
	nickpiggin@...oo.com.au, frankeh@...son.ibm.com, hugh@...itas.com
Subject: Re: [patch 6/6] Guest page hinting: s390 support.

Martin Schwidefsky wrote:
> That is the first block of state transitions: {Ur,Sr,Vr,Pr}
> You can go from any of the four states to any of the remaining three.
>   

You only mention page_set_{unused,stable,volatile}.  Is 
page_set_stable_if_present() the fourth.  And shouldn't that be 
"stable_if_clean":

     - potential volatile (P): the page has useful content. The host system
       is allowed to discard the content after it has checked the dirty bit
       of the page. It has to deliver a discard fault with the absolute
       address of the page if the guest tries to access it.

The use of "stable" in the function call and "volatile" in this 
description is a bit confusing.  My understanding is that a page in this 
state is either stable or volatile depending on whether its dirty, which 
makes sense, but it would be good to consistently refer to it in the 
same way.

Updated .dot attached.

    J

View attachment "gph.dot" of type "text/plain" (1229 bytes)

Download attachment "gph.pdf" of type "application/pdf" (16115 bytes)