linux-kernel - Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47D7372A.1010003@goop.org>
Date:	Tue, 11 Mar 2008 18:51:38 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ravikiran G Thirumalai <kiran@...lex86.org>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	virtualization@...ts.osdl.org, linux-kernel@...r.kernel.org,
	Glauber de Oliveira Costa <glommer@...il.com>,
	shai@...lex86.org
Subject: Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI)

Ravikiran G Thirumalai wrote:
> Would anyone have objection to have PARAVIRT depend on PCI, since the
> vsmp paravirt bits depend on PCI cfg space to determine if the system is
> vsmp?   If not, this patch would suffice.
>   

NAK.  Xen doesn't depend on PCI at all.   Why not make VSMP depend on 
PCI?  Then you could put something like:

#ifdef CONFIG_X86_VSMP
extern void vsmp_init(void);
extern int is_vsmp_box(void);
#else
static inline void vsmp_init(void)
{
}

static inline int is_vsmp_box(void)
{
	return 0;
}
#endif


in an appropriate header.

Hm, looks like arch/x86/kernel/Makefile should be

obj-$(CONFIG_X86_VSMP)		+= vsmp_64.o


rather than making it depend directly on CONFIG_PARAVIRT.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/