linux-kernel - Re: [RFC] correct flags to f_mode conversion in __dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1205347260.2925.0.camel@localhost.localdomain>
Date:	Wed, 12 Mar 2008 14:41:00 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, alan <alan@...hat.com>,
	aviro@...hat.com, drepper@...hat.com, hch@...radead.org,
	sds@...ho.nsa.gov, jmorris@...ei.org
Subject: Re: [RFC] correct flags to f_mode conversion in __dentry_open


On Wed, 2008-03-12 at 18:34 +0000, Al Viro wrote:
> On Wed, Mar 12, 2008 at 02:25:27PM -0400, Eric Paris wrote:
> > I recently tried to add an SELinux BUG_ON in the case where the kernel
> > made a permission request for no permissions and was able to stumble
> > over it with something as simple as
> > 
> > open("/dev/null", 3);
> > 
> > Notice that 3 == (O_RDWR | O_WRONLY)
> > 
> > First question, is 3 ever a valid flag from from userspace to sys_open?
> 
> Yes.  "Check for both read and write permissions, set neither FMODE_READ
> nor FMODE_WRITE".
> 
> Don't break drivers, please - some use that for "ioctl-only" opens,
> with special semantics for those.

Ok, I'll just make SELinux happy allow the request if we don't have
FMODE_READ or FMODE_WRITE set.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/