lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Mar 2008 13:45:23 -0700 From: Jeremy Fitzhardinge <jeremy@...p.org> To: Anthony Liguori <anthony@...emonkey.ws> CC: Jeremy Fitzhardinge <jeremy@...p.org>, akpm@...l.org, linux-s390@...r.kernel.org, frankeh@...son.ibm.com, nickpiggin@...oo.com.au, linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org, schwidefsky@...ibm.com, hugh@...itas.com Subject: Re: [patch 6/6] Guest page hinting: s390 support. Anthony Liguori wrote: > Jeremy Fitzhardinge wrote: > >>> With stable_if_clean you are refering to stable_if_present? >>> >> No. I misunderstood and thought that stable_if_present sets the Px >> state. I'd overlooked the writable flag on page_set_volatile(). >> >> >>> If yes the >>> answer is that this operation is used to get a page from Vx/Px back to >>> Sx but only if the page has not been discarded. >>> >> So you mean it will change Vr/Pr to Sr but everything else will fail? >> > > Well presumably Vp/Pr => Sp? Is is true that from the guest's > perspective, all of the 'p' states are identical to the 'r' states? > Vp should never happen, since you'd never preserve a V page. And surely it would be Pr -> Sr, since the hypervisor wouldn't push the page to backing store when you change the client state. > Do the host states even really need visibility to the guest at all? It > may be useful for the guest to be able to distinguish between Ur and Uz > but it doesn't seem necessary. Well, you implicitly see the hypervisor state. If you touch a [UV]z page then you get a fault telling you that the page has been taken away from you (I think). And it would definitely help with debugging (seems likely there's lots of scope for race conditions if you prematurely tell the hypervisor you don't need the page any more...). > BTW Jeremy, the .dot was very useful! Yes, there's no way I'd be able to get my head around this otherwise. BTW, here's an updated one with the host-driven events as dashed lines, and a couple of extra transitions I think should be in there (but waiting for Martin's confirmation). J View attachment "gph.dot" of type "text/plain" (1344 bytes) Download attachment "gph.pdf" of type "application/pdf" (16441 bytes)
Powered by blists - more mailing lists