linux-kernel - Re: [PATCH] x86: parocessor.h - use PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa79d98a0803121421gda8354akaa36cee2f225a2b4@mail.gmail.com>
Date:	Thu, 13 Mar 2008 00:21:37 +0300
From:	"Cyrill Gorcunov" <gorcunov@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant

Yep, it wold be more elegant, i'll fix it tomorrow. (sorry for
top-posting, i'm not on my local laptop now)

On 3/13/08, H. Peter Anvin <hpa@...or.com> wrote:
> Cyrill Gorcunov wrote:
> > This patch replaces numeric constant with an appropriate macro
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> >
> > ---
> >
> > Index: linux-2.6.git/include/asm-x86/processor.h
> > ===================================================================
> > --- linux-2.6.git.orig/include/asm-x86/processor.h	2008-02-20
> 19:14:57.000000000 +0300
> > +++ linux-2.6.git/include/asm-x86/processor.h	2008-03-12
> 23:10:02.000000000 +0300
> > @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
> >  /*
> >   * User space process size. 47bits minus one guard page.
> >   */
> > -#define TASK_SIZE64	(0x800000000000UL - 4096)
> > +#define TASK_SIZE64	(0x800000000000UL - PAGE_SIZE)
> >
> >  /* This decides where the kernel will search for a free chunk of vm
> >   * space during mmap's.
>
> Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)
>
> 	-hpa
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/