linux-kernel - Re: [patch 10/10] System z large page support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Mar 2008 23:14:31 +0100
From:	Gerald Schaefer <gerald.schaefer@...ibm.com>
To:	Dave Hansen <haveblue@...ibm.com>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [patch 10/10] System z large page support.

On Wed, 2008-03-12 at 10:52 -0700, Dave Hansen wrote:
> > 
> > +pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr)
> > +{
> > +       pgd_t *pgdp;
> > +       pud_t *pudp;
> > +       pmd_t *pmdp = NULL;
> > +
> > +       pgdp = pgd_offset(mm, addr);
> > +       pudp = pud_alloc(mm, pgdp, addr);
> > +       if (pudp)
> > +               pmdp = pmd_alloc(mm, pudp, addr);
> > +       return (pte_t *) pmdp;
> > +}
> 
> That looks pretty generic.  Why can't you share with the version we
> already have?

What version do you mean? Every architecture with hugetlbfs support has
its own huge_pte_alloc() function in arch/<arch>/mm/hugetlbfs.c, and
they are all doing slightly different things.

--
Gerald Schaefer


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/