| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200803121607.54348.david-b@pacbell.net> Date: Wed, 12 Mar 2008 15:07:53 -0800 From: David Brownell <david-b@...bell.net> To: avorontsov@...mvista.com Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function On Wednesday 12 March 2008, Anton Vorontsov wrote: > On Tue, Mar 11, 2008 at 01:02:38PM -0800, David Brownell wrote: > > On Tuesday 11 March 2008, Anton Vorontsov wrote: > > > > > > Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com> > > > > I'm curious why you want to change this. When it fails, a > > KERN_ERR message is emitted ... > > Ah, I missed that the gpiochip_add() issuing pr_err(), not pr_debug(). > > So, please just ignore that patch. OK ... > Though, printing errors from the > generic functions is confusing, you never know when your code or the > function you call should print the error. And usually generic functions > tend to be silent... The logic in this case was that I don't really expect platform setup code to check this stuff any more than it checks IRQ setup. But, as the comment says, if platform setup code goofs, it can cause un-bootable systems. Ergo the pr_err(). It could be argued either way; that's just what I did, way back when I noticed the issue. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists