linux-kernel - Re: pm_register() and pm_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080313141917.GA4117@linux-mips.org>
Date:	Thu, 13 Mar 2008 14:19:17 +0000
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Pavel Machek <pavel@....cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	David Howells <dhowells@...hat.com>
Subject: Re: pm_register() and pm_send_all()

On Thu, Mar 13, 2008 at 12:28:23PM +0000, Ralf Baechle wrote:

> Looks correct to me, thus ACK.
> 
> Spinning that a little further I wonder how useful the rest of the
> Alchemy code - which seems to only deal with devices - is.  If at all.
> I'm going to check with some Alchemy users if that code actually works or
> can be removed.  I think the latter.  Also there is the APM emulation
> available which provides similar functionality.

So here a patch do cleanup a part.  Probably more to come

From: Ralf Baechle <ralf@...ux-mips.org>

[MIPS] Alchey: Crapectomy after removal of pm_send_all calls.

Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>

 arch/mips/au1000/common/power.c |   20 --------------------
 1 file changed, 20 deletions(-)

Index: linux-mips/arch/mips/au1000/common/power.c
===================================================================
--- linux-mips.orig/arch/mips/au1000/common/power.c
+++ linux-mips/arch/mips/au1000/common/power.c
@@ -283,18 +283,6 @@ static int pm_do_sleep(ctl_table * ctl, 
 	return 0;
 }
 
-static int pm_do_suspend(ctl_table * ctl, int write, struct file *file,
-			 void __user *buffer, size_t * len, loff_t *ppos)
-{
-	if (!write) {
-		*len = 0;
-	} else {
-		suspend_mode = 1;
-	}
-	return 0;
-}
-
-
 static int pm_do_freq(ctl_table * ctl, int write, struct file *file,
 		      void __user *buffer, size_t * len, loff_t *ppos)
 {
@@ -408,14 +396,6 @@ static int pm_do_freq(ctl_table * ctl, i
 
 static struct ctl_table pm_table[] = {
 	{
-		.ctl_name 	= CTL_UNNUMBERED,
-		.procname	= "suspend",
-		.data		= NULL,
-		.maxlen		= 0,
-		.mode		= 0600,
-		.proc_handler	= &pm_do_suspend
-	},
-	{
 		.ctl_name	= CTL_UNNUMBERED,
 		.procname	= "sleep",
 		.data		= NULL,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/