linux-kernel - Re: pcibios_scanned needs to be set in ACPI? (was Re: 2.6.25-rc5: Reported regressions from 2.6.24)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080313153213.GB27723@kroah.com>
Date:	Thu, 13 Mar 2008 08:32:13 -0700
From:	Greg KH <greg@...ah.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Jeff Garzik <jeff@...zik.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Len Brown <len.brown@...el.com>
Subject: Re: pcibios_scanned needs to be set in ACPI?  (was Re: 2.6.25-rc5:
	Reported regressions from 2.6.24)

On Thu, Mar 13, 2008 at 11:06:10AM +0100, Guennadi Liakhovetski wrote:
> On Wed, 12 Mar 2008, Greg KH wrote:
> 
> > On Wed, Mar 12, 2008 at 04:09:17PM -0700, Linus Torvalds wrote:
> > > 
> > > 
> > > On Wed, 12 Mar 2008, Greg KH wrote:
> > > > 
> > > > I can't get a box here to produce both of those PCI: messages myself,
> > > > and neither can Len, so something is really odd here.
> > 
> > Ok, stupid me, this was my fault.  I was assuming that pci busses would
> > never be registered multiple times with the pci core.  Obviously this
> > isn't true.  The previous patch I proposed was only paying attention to
> > the PCI devices, and that logic is just fine (it's already protected
> > when it is attempted to be registered multiple times.)
> > 
> > So, the patch below fixes the issue for me, and reboot seems to work as
> > well.
> > 
> > Guennadi, can you test this out on your machine?
> 
> Yes, it fixes all _3_ startup warnings and lets the machine reboot and 
> power off again. 3 warnings are the 2 reported as a regression from 
> 2.6.24, and one present also under 2.6.24:
> 
> PCI: Probing PCI hardware
> sysfs: duplicate filename 'bridge' can not be created

Yes, I noticed that if you were having this problem, .24 would also be
complaining to you about creating sysfs links.  I'll make up a .24 patch
for -stable after this.

Kay just pointed out that I can use a struct device field instead of
creating my own in the bus device, so I'll simplify the patch and then
send it to Linus in a bit.

Thanks so much for testing quickly and letting me know.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/