linux-kernel - Re: [PATCH] logical-bitwise & confusion in se401_init() (was: logical-bitwise & confusion in se401

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080313173000.5bd1d039@cuia.boston.redhat.com>
Date:	Thu, 13 Mar 2008 17:30:00 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>, pe1rxq@...at.org,
	linux-usb@...r.kernel.org, video4linux-list@...hat.com,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] logical-bitwise & confusion in se401_init() (was:
 logical-bitwise & confusion in se401_init()?)

On Thu, 13 Mar 2008 16:51:29 +0100
Roel Kluin <12o3l@...cali.nl> wrote:

> -	if (!cp[2] && SE401_FORMAT_BAYER) {
> +	if (!cp[2] & SE401_FORMAT_BAYER) {
>  		err("Bayer format not supported!");
>  		return 1;
>  	}

Would it be better to put in some additional parenthesis?

	if (!(cp[2] & SE401_FORMAT_BAYER)) {

-- 
All Rights Reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/