lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Mar 2008 14:48:02 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Jan Kara <jack@...e.cz> Cc: linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, jengelh@...putergmbh.de, mjt@....msk.ru Subject: Re: [PATCH 1/4] quota: Quota core changes for quotaon on remount On Thu, 13 Mar 2008 14:04:12 +0100 Jan Kara <jack@...e.cz> wrote: > +static inline int DQUOT_ON_REMOUNT(struct super_block *sb) > +{ > + int cnt; > + int ret = 0, err; > + > + if (!sb->s_qcop || !sb->s_qcop->quota_on) > + return -ENOSYS; > + for (cnt = 0; cnt < MAXQUOTAS; cnt++) { > + err = sb->s_qcop->quota_on(sb, cnt, 0, NULL, 1); > + if (err < 0 && !ret) > + ret = err; > + } > + return ret; > +} > + That's about ten times too large to be inlined. Oh well. Sometime could you please take a look at uninlining some of the porkier functions in quotaops.h, and maybe convert them to lower case? For the latter we can do #define DQUOT_ON_REMOUNT(sb) dquot_on_remount(sb) etc, then remove those macros when everything has been converted and we've given any out-of-tree filesytem developers time to update, etc. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists