linux-kernel - Re: [PATCH -mm] do not check condition twice in WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0803122147260.3557@woody.linux-foundation.org>
Date:	Wed, 12 Mar 2008 21:47:52 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Johannes Weiner <hannes@...urebad.de>
cc:	Dave Young <hidave.darkstar@...il.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	Marcin Slusarz <marcin.slusarz@...il.com>,
	paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH -mm] do not check condition twice in WARN_ON_SECS



On Wed, 12 Mar 2008, Johannes Weiner wrote:
> 
> What's wrong with:
> 
> #define WARN_ON_SECS(condition, secs) \
> 	WARN_ON(condition && __ratelimit(secs * HZ, 1))

Add parenthesis around the arguments, please.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/