[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <31114.1205495168@redhat.com>
Date: Fri, 14 Mar 2008 11:46:08 +0000
From: David Howells <dhowells@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: dhowells@...hat.com, torvalds@...ux-foundation.org,
kwc@...i.umich.edu, arunsr@....iitk.ac.in, dwalsh@...hat.com,
linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] KEYS: Make the keyring quotas controllable through /proc/sys
Andrew Morton <akpm@...ux-foundation.org> wrote:
> > +#ifdef CONFIG_SYSCTL
> > +extern ctl_table key_sysctls[];
> > +#endif
>
> I've been going around telling people to not bother with the ifdefs here.
> Upside: looks nicer. Downside: defers the build error from compile-time to
> link-time.
Should this extern actually be in include/linux/sysctl.h? I'd rather not put
it in include/linux/key.h as that means that key.h must include sysctl.h just
to get a definition of ctl_table. Conversely, however, sysctl.h doesn't need
to include key.h to include the above extern.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists