linux-kernel - Re: [PATCH] mm: fix boundary checking in free_bootmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080314165336.GS2522@one.firstfloor.org>
Date:	Fri, 14 Mar 2008 17:53:36 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Andi Kleen <andi@...stfloor.org>, Andi Kleen <ak@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>, mingo@...e.hu,
	clameter@....com, linux-kernel@...r.kernel.org,
	Yasunori Goto <y-goto@...fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH] mm: fix boundary checking in free_bootmem_core

On Fri, Mar 14, 2008 at 09:44:50AM -0700, Yinghai Lu wrote:
> On 14 Mar 2008 12:58:44 +0100, Andi Kleen <andi@...stfloor.org> wrote:
> > "Yinghai Lu" <yhlu.kernel@...il.com> writes:
> >  >
> >  > then i tried to reserve 64M or 128M RAM before that, and free that
> >  > before gart/switotble try to allloc_bootmem under 4g.
> >
> >  Sounds like an incredible hack. There are far better ways to do that
> >  for bootmem allocations. e.g. you can just specify a high enough "goal"
> >  That is how swiotlb solves a similar problem (at least before my
> >  mask allocator rewrite)
> 
> I don't think so.
> 
> anyway, otherway to workaround it is
> change
>                 return __earlyonly_bootmem_alloc(node, size, size,
>                                 __pa(MAX_DMA_ADDRESS));
> in vmemmap_alloc_block to
>                 return __earlyonly_bootmem_alloc(node, size, size,
>                                 __pa(MAX_DMA_ADDRESS + (1<<27)));
> to make room for gart. but that is global change. and may affect other
> platform. 

You can just make it an optional architecture defined macro

> and don't make sure gart will get it.

Has nothing to do with the gart?


> 
> also i assume swiotlb need that range is less than 4g.

The normal rule is that anybody who needs big bootmem allocations
need to make sure they're high enough to not fill up first 4GB.
For small allocations like most of bootmem it doesn't matter because 
they're, um, small.

If vmemmap doesn't do that vmemmap needs to be fixed.

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/