linux-kernel - Re: [PATCH] struct export_operations: adjust comments to match current members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Mar 2008 13:05:27 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...ux-foundation.org, hch@....de, dhowells@...hat.com,
	marc.c.dionne@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] struct export_operations: adjust comments to match
 current members

On Fri, 14 Mar 2008 13:11:29 +0000
David Howells <dhowells@...hat.com> wrote:

> 
> From: "Marc Dionne" <marc.c.dionne@...il.com>
> 
> The comments in the definition of struct export_operations don't match the
> current members.
> 
> Add a comment for the 2 new functions and remove 2 comments for unused ones.
> 
> Signed-off-by: Marc Dionne <marc.c.dionne@...il.com>
> Acked-by: David Howells <dhowells@...hat.com>

I changed this to Signed-off-by:.  You were in the delivery path.

> ---
>  include/linux/exportfs.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/exportfs.h b/include/linux/exportfs.h
> index 51d2141..adcbb05 100644
> --- a/include/linux/exportfs.h
> +++ b/include/linux/exportfs.h
> @@ -49,11 +49,11 @@ struct fid {
> 
>  /**
>   * struct export_operations - for nfsd to communicate with file systems
> - * @decode_fh:      decode a file handle fragment and return a &struct dentry
>   * @encode_fh:      encode a file handle fragment from a dentry
> + * @fh_to_dentry:   find the implied object and get a dentry for it
> + * @fh_to_parent:   find the implied object's parent and get a dentry for it
>   * @get_name:       find the name for a given inode in a given directory
>   * @get_parent:     find the parent of a given directory
> - * @get_dentry:     find a dentry for the inode given a file handle
> sub-fragment

Someone is wordwrapping.

>   *
>   * See Documentation/filesystems/Exporting for details on how to use
>   * this interface correctly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/