linux-kernel - Re: [PATCH] mm: make reserve_bootmem can crossed the nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440803131835u4e506d69l4f116eb49d9ee9b2@mail.gmail.com>
Date:	Thu, 13 Mar 2008 18:35:51 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Ingo Molnar" <mingo@...e.hu>, "Andi Kleen" <ak@...e.de>,
	"Christoph Lameter" <clameter@....com>,
	linux-kernel@...r.kernel.org,
	"Yasunori Goto" <y-goto@...fujitsu.com>
Subject: Re: [PATCH] mm: make reserve_bootmem can crossed the nodes

On Thu, Mar 13, 2008 at 6:34 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@...fujitsu.com> wrote:
> On Thu, 13 Mar 2008 16:45:42 -0700
>  "Yinghai Lu" <yhlu.kernel@...il.com> wrote:
>  > int __init reserve_bootmem(unsigned long addr, unsigned long size,
>  >                           int flags)
>  >  {
>  > -     return reserve_bootmem_core(NODE_DATA(0)->bdata, addr, size, flags);
>  > +     int ret;
>  > +     bootmem_data_t *bdata;
>  > +     list_for_each_entry(bdata, &bdata_list, list) {
>  > +             ret = can_reserve_bootmem_core(bdata, addr, size, flags);
>  > +             if (ret < 0)
>  > +                     return ret;
>  > +     }
>  > +     list_for_each_entry(bdata, &bdata_list, list)
>  > +             reserve_bootmem_core(bdata, addr, size, flags);
>  > +     return 0;
>  >  }
>
>  why list_for_each twice ?

first_for_each only check if we can reserve that.
second will do the reserve job.

Thanks

Yinghai Lu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/