linux-kernel - Re: ACPI lockdep warning on boot, 2.6.25-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080315131611.GA4828@ucw.cz>
Date:	Sat, 15 Mar 2008 14:16:11 +0100
From:	Pavel Machek <pavel@....cz>
To:	Venki Pallipadi <venkatesh.pallipadi@...el.com>
Cc:	Len Brown <lenb@...nel.org>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Miklos Szeredi <miklos@...redi.hu>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: ACPI lockdep warning on boot, 2.6.25-rc5

Hi!

> @@ -421,7 +423,9 @@
>  		else
>  			acpi_safe_halt();
>  
> -		local_irq_enable();
> +		if (irqs_disabled())
> +			local_irq_enable();
> +
>  		return;
>  	}
>  
> @@ -530,7 +534,9 @@
>  		 *       skew otherwise.
>  		 */
>  		sleep_ticks = 0xFFFFFFFF;
> -		local_irq_enable();
> +		if (irqs_disabled())
> +			local_irq_enable();
> +
>  		break;
>  
>  	case ACPI_STATE_C2:

That's pretty ugly. Could the code be modified to have interrupt
consistent at this point?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/