linux-kernel - Re: [PATCH 7/7] drivers/net/atl1/atl1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080315171609.05db507b@osprey.hogchain.net>
Date:	Sat, 15 Mar 2008 17:16:09 -0500
From:	Jay Cliburn <jcliburn@...il.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	csnook@...hat.com, atl1-devel@...ts.sourceforge.net,
	jgarzik@...ox.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused
 variable

On Sat, 15 Mar 2008 17:05:02 +0100 (CET)
Julia Lawall <julia@...u.dk> wrote:

> From: Julia Lawall <julia@...u.dk>
> 
> The variable update_rx is initialized but never used otherwise.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
> 
> (
> extern T i;
> |
> - T i;
>   <+... when != i
> - i = C;
>   ...+>
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Acked-by: Jay Cliburn <jacliburn@...lsouth.net>

> ---
>  drivers/net/atl1/atl1_main.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff -u -p a/drivers/net/atl1/atl1_main.c
> b/drivers/net/atl1/atl1_main.c ---
> a/drivers/net/atl1/atl1_main.c	2008-03-12 14:13:13.000000000
> +0100 +++ b/drivers/net/atl1/atl1_main.c	2008-03-15
> 16:18:08.000000000 +0100 @@ -1765,15 +1765,12 @@ static irqreturn_t
> atl1_intr(int irq, vo { struct atl1_adapter *adapter =
> netdev_priv(data); u32 status;
> -	u8 update_rx;
>  	int max_ints = 10;
>  
>  	status = adapter->cmb.cmb->int_stats;
>  	if (!status)
>  		return IRQ_NONE;
>  
> -	update_rx = 0;
> -
>  	do {
>  		/* clear CMB interrupt status at once */
>  		adapter->cmb.cmb->int_stats = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/