linux-kernel - Re: [PATCH 1/8] cleanup ntp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0803150418560.1791@scrub.home>
Date:	Sat, 15 Mar 2008 04:21:34 +0100 (CET)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	john stultz <johnstul@...ibm.com>
cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 1/8] cleanup ntp.c

Hi,

On Fri, 14 Mar 2008, john stultz wrote:

> Ah crud. Ingo sent very similar changes to me a few weeks ago, and I've
> been too pinched for time to test and send them out. 
> 
> I'll spend some time today to layer his fixes as well as my own cleanups
> on top. 

What fixes?

> > +static void ntp_update_offset(long offset)
> > +{
> > +	long mtemp;
> 
> Could we change this to a more descriptive name?
> 
> Maybe last_update_interval?

It's a local variable, so IMO temp works just fine, it's not that 
difficult to figure out how it's used (e.g. it's like using loop_index 
instead of i).

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/