linux-kernel - Re: Oops in NFSv4 server in 2.6.23.17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18397.43768.705353.514972@notabene.brown>
Date:	Mon, 17 Mar 2008 10:19:20 +1100
From:	Neil Brown <neilb@...e.de>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Lukas Hejtmanek <xhejtman@....muni.cz>, nfsv4@...ux-nfs.org,
	linux-kernel@...r.kernel.org
Subject: Re: Oops in NFSv4 server in 2.6.23.17

On Friday March 14, bfields@...ldses.org wrote:
> On Fri, Mar 14, 2008 at 04:05:10PM -0400, bfields wrote:
> > I find that a little contorted.  So I'll go ahead and submit this small
> > patch to 2.6.25 and stable now (I have since managed to reproduce what I
> > believe is your bug, though my symptoms were a little different), and
> > then submit to 2.6.26 some cleanup which makes this more understandable,
> 
> Here's an attempt.  We could break up fh_verify even more, though.--b.

Looks like a good attempt.

My only suggestion would be to put a comment at the top of
nfsd_set_fh_dentry explaining what it does and who calls it.

It's long past time that code had some spring cleaning !!

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/