linux-kernel - Re: [PATCH] x86: don't allow KVM_CLOCK without HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47DD00C4.2070100@qumranet.com>
Date:	Sun, 16 Mar 2008 13:13:08 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	lkml <linux-kernel@...r.kernel.org>, linux-next@...r.kernel.org,
	kvm-devel@...ts.sourceforge.net, tglx <tglx@...utronix.de>,
	mingo <mingo@...hat.com>, hpa <hpa@...or.com>
Subject: Re: [PATCH] x86: don't allow KVM_CLOCK without HAVE_KVM

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
>
> Make KVM_CLOCK depend on HAVE_KVM.  Otherwise a Voyager build can
> fail with:
>
>   CC      arch/x86/kernel/asm-offsets.s
> In file included from include2/asm/irqflags.h:59,
>                  from /local/linsrc/next-20080314/include/linux/irqflags.h:46,
>                  from include2/asm/system.h:11,
>                  from include2/asm/processor.h:21,
>                  from include2/asm/atomic_32.h:5,
>                  from include2/asm/atomic.h:2,
>                  from /local/linsrc/next-20080314/include/linux/crypto.h:20,
>                  from /local/linsrc/next-20080314/arch/x86/kernel/asm-offsets_32.c:7,
>                  from /local/linsrc/next-20080314/arch/x86/kernel/asm-offsets.c:2:
> include2/asm/paravirt.h: In function 'startup_ipi_hook':
> include2/asm/paravirt.h:856: error: 'struct pv_apic_ops' has no member named 'startup_ipi_hook'
> include2/asm/paravirt.h:856: error: 'struct pv_apic_ops' has no member named 'startup_ipi_hook'
> include2/asm/paravirt.h:856: error: memory input 4 is not directly addressable
> make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[1]: *** [prepare0] Error 2
> make: *** [sub-make] Error 2
>
>   

Looks like it's a general paravirt vs voyager issue, nothing kvmclock 
specific about it.  Wouldn't it be better to have voyager and paravirt 
mutually exclude each other, rather than every paravirt user?

HAVE_KVM is intended for the host, not the guest, btw.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/