linux-kernel - Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440803170031u75167e5m301f65049b6d62ff@mail.gmail.com>
Date:	Mon, 17 Mar 2008 00:31:29 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, pj@....com, linux-mm@...ck.org,
	nickpiggin@...oo.com.au
Subject: Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator

On Mon, Mar 17, 2008 at 12:17 AM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
>
> On Mon, Mar 17, 2008 at 12:02 AM, Andi Kleen <andi@...stfloor.org> wrote:
>  > > node_boot_start is not page aligned?
>  >
>  >  It is, but it is not necessarily GB aligned and without this
>  >  change sometimes alloc_bootmem when requesting GB alignment
>  >  doesn't return GB aligned memory. This was a nasty problem
>  >  that took some time to track down.
>
>  or preferred has some problem?
>
>
>  preferred = PFN_DOWN(ALIGN(preferred, align)) + offset;
>

when node_boot_start is 512M alignment, and align is 1024M, offset
could be 512M. it seems
i = ALIGN(i, incr) need to do sth with offset...

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/