linux-kernel - Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440803170053n32a1c918h2ff2a32abef44050@mail.gmail.com>
Date:	Mon, 17 Mar 2008 00:53:43 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, pj@....com, linux-mm@...ck.org,
	nickpiggin@...oo.com.au
Subject: Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator

On Mon, Mar 17, 2008 at 12:41 AM, Andi Kleen <andi@...stfloor.org> wrote:
> > when node_boot_start is 512M alignment, and align is 1024M, offset
>  > could be 512M. it seems
>  > i = ALIGN(i, incr) need to do sth with offset...
>
>  It's possible that there are better fixes for this, but at least
>  my simple patch seems to work here. I admit I was banging my
>  head against this for some time and when I did the fix I just
>  wanted the bug to go away and didn't really go for subtleness.
>
>  The bootmem allocator is quite spaghetti in fact, it could
>  really need some general clean up (although it's' not quite
>  as bad yet as page_alloc.c)

i = ALIGN(i+offset, incr) - offset;

also the one in fail_block...

only happen when align is large than alignment of node_boot_start.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/