linux-kernel - Re: [PATCH libata-dev#upstream-fixes] ahci: request all PCI BARs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47DE63B0.2070209@garzik.org>
Date:	Mon, 17 Mar 2008 08:27:28 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Tejun Heo <htejun@...il.com>
CC:	IDE/ATA development list <linux-ide@...r.kernel.org>,
	linux-pci@...ey.karlin.mff.cuni.cz,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH libata-dev#upstream-fixes] ahci: request all PCI BARs

Tejun Heo wrote:
> ahci is often implemented with accompanying SFF compatible interface
> and legacy IDE driver may attach to the legacy IO ports when the
> controller is already claimed by ahci and vice-versa.  This patch
> makes ahci use pcim_iomap_regions_request_all() so that all IO regions
> are claimed on attach.
> 
> Signed-off-by: Tejun Heo <htejun@...il.com>
> ---
>  drivers/ata/ahci.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> Index: work/drivers/ata/ahci.c
> ===================================================================
> --- work.orig/drivers/ata/ahci.c
> +++ work/drivers/ata/ahci.c
> @@ -2234,7 +2234,10 @@ static int ahci_init_one(struct pci_dev 
>  	if (rc)
>  		return rc;
>  
> -	rc = pcim_iomap_regions(pdev, 1 << AHCI_PCI_BAR, DRV_NAME);
> +	/* AHCI controllers often implement SFF compatible interface.
> +	 * Grab all PCI BARs just in case.
> +	 */
> +	rc = pcim_iomap_regions_request_all(pdev, 1 << AHCI_PCI_BAR, DRV_NAME);
>  	if (rc == -EBUSY)
>  		pcim_pin_device(pdev);

applied this, and the devres function


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/