linux-kernel - Re: [PATCH -mm 1/5] list.h: add list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1205766798.8514.318.camel@twins>
Date:	Mon, 17 Mar 2008 16:13:18 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, ananth@...ibm.com,
	jkenisto@...ibm.com, linux-kernel@...r.kernel.org,
	systemtap@...rces.redhat.com, prasanna@...ibm.com,
	shaohua.li@...el.com, davem@...emloft.net, fche@...hat.com
Subject: Re: [PATCH -mm 1/5] list.h: add list_singleton

On Mon, 2008-03-17 at 11:04 -0400, Masami Hiramatsu wrote:
> Hi Peter,
> 
> Peter Zijlstra wrote:
> >>> So I guess we can proceed with your list_singleton(), but I'd just like to
> >>> flag this possible confusion, see what people think..
> > 
> > May I kindly ask to please not use the singleton name like this. It does
> > not implement the singleton pattern and will be a great confusion for
> > everybody who expects it to.
> 
> Indeed.
> 
> I have some other candidates.
> - list_single
> - list_has_one
> - list_one
> 
> Could you tell me which or some other name you recommend?

I think list_has_one() or list_is_singular() are good names, they convey
they are a test for a condition by using a form of be.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/