linux-kernel - Re: + dm-raid1-bitops-bug.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080317154557.GD6500@osiris.boeblingen.de.ibm.com>
Date:	Mon, 17 Mar 2008 16:45:57 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	mm-commits@...r.kernel.org, agk@...hat.com, jbrassow@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: + dm-raid1-bitops-bug.patch added to -mm tree

> Subject: dm raid1: bitops bug
> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> Commit 8f0205b798f926e2745de5fdebf0a8605c621de6
> "dm raid1: handle recovery failures" introduces a test_bit on an
> integer. test_bit is only defined to do something useful on arrays
> of long. Remove the test_bit code and use hand coded test bit
> instead.
> 
> Cc: Jonathan Brassow <jbrassow@...hat.com>
> Cc: Alasdair G Kergon <agk@...hat.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/md/dm-raid1.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff -puN drivers/md/dm-raid1.c~dm-raid1-bitops-bug drivers/md/dm-raid1.c
> --- a/drivers/md/dm-raid1.c~dm-raid1-bitops-bug
> +++ a/drivers/md/dm-raid1.c
> @@ -758,7 +758,8 @@ static void recovery_complete(int read_e
>  {
>  	struct region *reg = (struct region *)context;
>  	struct mirror_set *ms = reg->rh->ms;
> -	int m, bit = 0;
> +	unsigned int mask = 1;
> +	int m;
> 
>  	if (read_err) {
>  		/* Read error means the failure of default mirror. */
> @@ -776,10 +777,10 @@ static void recovery_complete(int read_e
>  		for (m = 0; m < ms->nr_mirrors; m++) {
>  			if (&ms->mirror[m] == get_default_mirror(ms))
>  				continue;
> -			if (test_bit(bit, &write_err))
> +			if (write_err & mask)
>  				fail_mirror(ms->mirror + m,
>  					    DM_RAID1_SYNC_ERROR);
> -			bit++;
> +			mask <<= 1;
>  		}
>  	}

Could we have this patch or something similar in 2.6.25, please?
It's broken doing a test_bit() on an int since the result is random
whenever sizeof(int) != sizeof(long).
It might also lead to exceptions if an architecture requires a
sizeof(long) alignment for test_bit().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/