linux-kernel - Re: [PATCH] fix signal return code when enable CONFIG_OABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080317183936.GD32354@flint.arm.linux.org.uk>
Date:	Mon, 17 Mar 2008 18:39:36 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	ye janboe <janboe.ye@...il.com>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix signal return code when enable CONFIG_OABI_COMPAT

On Fri, Mar 07, 2008 at 07:09:22PM +0800, ye janboe wrote:
> Russell
> 
> I resubmit my patch, please review it.

Having thought about this, yes, this fix will do.  Please submit to the
patch system.  Thanks.

> Thanks
> 
> commit 31644e57359644d3f376f293f1a45b7c181175b6
> Author: janboe <janboe@...il.com>
> Date:   Thu Mar 6 23:00:23 2008 +0800
> 
>     fix signal return code when enable CONFIG_OABI_COMPAT
>     Signed-off-by: Janboe Ye <janboe.ye@...il.com>
> 
> diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
> index 54cdf1a..ef2f86a 100644
> --- a/arch/arm/kernel/signal.c
> +++ b/arch/arm/kernel/signal.c
> @@ -26,8 +26,8 @@
>  /*
>   * For ARM syscalls, we encode the syscall number into the instruction.
>   */
> -#define SWI_SYS_SIGRETURN      (0xef000000|(__NR_sigreturn))
> -#define SWI_SYS_RT_SIGRETURN   (0xef000000|(__NR_rt_sigreturn))
> +#define SWI_SYS_SIGRETURN
> (0xef000000|(__NR_sigreturn)|(__NR_OABI_SYSCALL_BASE))
> +#define SWI_SYS_RT_SIGRETURN
> (0xef000000|(__NR_rt_sigreturn)|(__NR_OABI_SYSCALL_BASE))
> 
>  /*
>   * With EABI, the syscall number has to be loaded into r7.
> 
> 
> 2008/3/6, Russell King - ARM Linux <linux@....linux.org.uk>:
> > On Thu, Mar 06, 2008 at 11:14:50PM +0800, ye janboe wrote:
> >  > commit b4e8bde513a9a477c30c8769073ced7b59676d48
> >  > Author: janboe <janboe.ye@...il.com>
> >  > Date:   Thu Mar 6 23:00:23 2008 +0800
> >  >
> >  >     fix signal return code when enable CONFIG_OABI_COMPAT.
> >  >     because this will make kernel report this syscall obsolete.
> >  >     Signed-off-by: Janboe Ye <janboe.ye@...il.com>
> >
> >
> > This is all horribly broken for OABI compat anyway (because __NR_* don't
> >  contain the right prefix).  So this patch doesn't actually fix the real
> >  problem.
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/