[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080318011811.252c7c59.akpm@linux-foundation.org>
Date: Tue, 18 Mar 2008 01:18:11 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Miklos Szeredi <miklos@...redi.hu>
Cc: a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [patch 4/8] mm: allow not updating BDI stats in
end_page_writeback()
On Tue, 18 Mar 2008 09:11:49 +0100 Miklos Szeredi <miklos@...redi.hu> wrote:
> >
> > Reason: bdi_cap_writeback_dirty() is kinda weirdly intrepreted to mean
> > various different things in different places and we really should separate
> > its multiple interpretations into separate flags.
> >
> > Note that this becomes a standalone VFS cleanup patch, and the fuse code
> > can then just use it later on.
>
> Hmm, I can see two slightly different meanings of bdi_cap_writeback_dirty():
>
> 1) need to call ->writepage (sync_page_range(), ...)
> 2) need to update BDI stats (test_clear_page_writeback(), ...)
>
> If these two were different flags, then fuse could set the
> NEED_WRITEPAGE flag, but clear the NEED_UPDATE_BDI_STATS flag, and do
> it manually.
>
> Does that sound workable?
Yup, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists