[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200803181403.37969.bzolnier@gmail.com>
Date: Tue, 18 Mar 2008 14:03:36 +0100
From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To: Anders Eriksson <aeriksson@...tmail.fm>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
"Rafael J. Wysocki" <rjw@...k.pl>,
Jens Axboe <jens.axboe@...cle.com>,
Ingo Molnar <mingo@...e.hu>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.25-rc4
On Tuesday 18 March 2008, Anders Eriksson wrote:
>
> torvalds@...ux-foundation.org said:
> > So try to see if you get to ide_error(), which is where Bartlomiejs latest
> > patch was in effect - but add a few printk's there to print out the 'stat'
> > variable etc to see if it actually triggers. And maybe a WARN_ON(1) to get
> > the trace..
>
> Seems we don't. At least this addition didn't yield anything:
>
> ide_startstop_t ide_error (ide_drive_t *drive, const char *msg, u8 stat)
> {
> ide_hwif_t *hwif = drive->hwif;
> struct request *rq = hwif->hwgroup->rq;
> u8 err;
>
> printk("ide_error(msg=%s, stat=%i)\n",msg,stat);
> WARN_ON(1);
> if (rq && rq->cmd_type == REQ_TYPE_ATA_TASKFILE) {
>
Could you also add printk() to task_in_intr()?
---
drivers/ide/ide-taskfile.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/ide/ide-taskfile.c
===================================================================
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -433,6 +433,8 @@ static ide_startstop_t task_in_intr(ide_
/* new way for dealing with premature shared PCI interrupts */
if (!OK_STAT(stat, DRQ_STAT, BAD_R_STAT)) {
+ printk(KERN_INFO "%s: %s: stat=%02x\n",
+ __func__, drive->name, stat);
if (stat & (ERR_STAT | DRQ_STAT))
return task_error(drive, rq, __FUNCTION__, stat);
/* No data yet, so wait for another IRQ. */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists