[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200803171845.29232.david-b@pacbell.net>
Date: Mon, 17 Mar 2008 17:45:28 -0800
From: David Brownell <david-b@...bell.net>
To: Rene Herman <rene.herman@...access.nl>
Cc: "Lev A. Melnikovsky" <melnikovsky@...l.ru>,
Alessandro Suardi <alessandro.suardi@...il.com>,
Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: ehci-hcd affects hda speed
On Monday 17 March 2008, Rene Herman wrote:
> On 18-03-08 01:24, Lev A. Melnikovsky wrote:
>
> > DB> On Monday 17 March 2008, Rene Herman wrote:
> > DB> > + case PCI_VENDOR_ID_VIA:
> > DB> > + if (pdev->device == 0x3104 && pdev->revision >= 0x60) {
> >
> > DB> Unless you have specific docs from VIA saying that this register
> > DB> isn't revision-specific (at least in the sense that all revisions
> > DB> after 0x60 define that bit in that way), this should probably be a
> > DB> switch on pdev->revision and just include the known-safe revisions.
>
> > May I suggest this should be a module parameter? Because a side effect is
> > a USB slow-down, which may be more important for somebody...
>
> If the 10us is a EHCI specification, I'd personally think not. But if need
> be...
It's not exactly a specification, but it's what they use as an
example of a "reasonable" value. I think pretty much everyone
except VIA uses it as-is. Since 1 usec is such a broken value,
I see no reason to support anything except 10 usec.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists