linux-kernel - [PATCH] ZISOFS : readpage over i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080318005016.GA2776@darkstar.te-china.tietoenator.com>
Date:	Tue, 18 Mar 2008 08:50:16 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	akpm@...ux-foundation.org, jack@...e.cz, chris@...uxinfotag.de
Subject: [PATCH] ZISOFS : readpage over i_size fix

Read request over i_size will be dealed in do_generic_file_read.
So we just return 0 to avoid getting -EIO as normal reading,
let do_generic_file_read do the rest.

At the same time we need unlock the page to avoid system stuck.

For the bug report please see
http://bugzilla.kernel.org/show_bug.cgi?id=10227

Signed-off-by: Dave Young <hidave.darkstar@...il.com>
Acked-by: Jan Kara <jack@...e.cz>

---
fs/isofs/compress.c |   10 ++++++++++
1 file changed, 10 insertions(+)

diff -upr linux/fs/isofs/compress.c linux.new/fs/isofs/compress.c
--- linux/fs/isofs/compress.c	2008-03-17 18:07:44.000000000 +0800
+++ linux.new/fs/isofs/compress.c	2008-03-17 18:13:14.000000000 +0800
@@ -72,6 +72,16 @@ static int zisofs_readpage(struct file *
 	offset = index & ~zisofs_block_page_mask;
 	blockindex = offset >> zisofs_block_page_shift;
 	maxpage = (inode->i_size + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
+
+	/* Here the outsize request we just return 0 because
+	do_generic_file_read will handle this for us */
+
+	if (page->index >= maxpage) {
+		SetPageUptodate(page);
+		unlock_page(page);
+		return 0;
+	}
+
 	maxpage = min(zisofs_block_pages, maxpage-offset);
 
 	for ( i = 0 ; i < maxpage ; i++, offset++ ) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/