linux-kernel - Re: [PATCH] kprobes: correct regs->ip value in post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080318155645.GA6794@in.ibm.com>
Date:	Tue, 18 Mar 2008 21:26:45 +0530
From:	Ananth N Mavinakayanahalli <ananth@...ibm.com>
To:	Yakov Lerner <iler.ml@...il.com>
Cc:	mhiramat@...hat.com, prasanna@...ibm.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kprobes: correct regs->ip value in post_hander()

On Tue, Mar 18, 2008 at 09:26:49AM -0500, Yakov Lerner wrote:
> From: "Yakov Lerner" <iler.ml@...il.com>
> 
>  This patch corrects the value of regs->ip in post_handler(). Prior to
>  this patch, post_handler() was given address meaningless to the user in 
>  regs->ip. The expected value is address of the next instruction to be 
>  executed after kprobed instruction. This patch simply swaps the order of
>  post_handler() and resume_execution(). post_handler() now sees the 
>  corrected, expected value in regs->ip. post_handler() is now called after
>  after resume_execution(), not before.
> 
>  Only x86 platform was tested. Arm arch needs no changes.
> 
> Signed-off-by: Yakov Lerner <iler.ml@...il.com>

Tested on powerpc.

Acked-by: Ananth N Mavinakayanahalli <ananth@...ibm.com>

Thanks Yakov!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/