linux-kernel - Re: Linux 2.6.25-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Mar 2008 12:14:02 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Anders Eriksson <aeriksson@...tmail.fm>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Jens Axboe <jens.axboe@...cle.com>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.25-rc4

On Wednesday 19 March 2008, Linus Torvalds wrote:
> 
> On Wed, 19 Mar 2008, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Your patch is more robust and we should go with it
> > (and thanks for fixing this bug!).
> 
> Ok, I committed the patch as-is, since it's what Anders tested, but I'm 
> not at all convinced that it is necessarily the best or final form. The 

Thanks.

> things I am aware of but didn't think about all *that* deeply:
> 
>  - do we get return values etc right (ie if we complete the command that 
>    didn't give any data, how do we account the size of it?)

Yeah, closer look would be needed there.

>  - what about that remaining old unexpected case? I kept the "wait for it 
>    with timeout" behaviour for the case that wasn't an issue here, but if 
>    it really is a shared interrupt, that seems like it's going to always 
>    reset the timeout to WAIT_WORSTCASE, which doesn't sound really right.

This shared IRQs quirk should no longer be necessary so probably the best
way to handle BSY there would be to give drive some last chance and if it
is still BSY treat is as error.

> so I think this particular bug is fixed and we should be better off, but 
> I'm definitely not claiming that the code shouldn't have people thinking 
> about improving it..

Definitevely, I'll try to address "old unexpected case" for 2.6.26
(+ I'll keep looking for other issues as time permits) and of course
I'll be happy to review/merge any patches improving this area.

Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/