linux-kernel - Re: [PATCH 6/6] USB: enable USB-PERSIST by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0803191727030.2504-100000@netrider.rowland.org>
Date:	Wed, 19 Mar 2008 17:35:23 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Mark Lord <lkml@....ca>
cc:	Greg Kroah-Hartman <gregkh@...e.de>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] USB: enable USB-PERSIST by default

On Wed, 19 Mar 2008, Mark Lord wrote:

> Greg Kroah-Hartman wrote:
> > From: Alan Stern <stern@...land.harvard.edu>
> > 
> > This patch (as1052) enables USB-PERSIST for all devices by default.
> > The user won't have to remember to enable it explicitly for devices
> > containing mounted filesystems.
> > 
> > Eventually userspace tools like hal may be able to set the persist
> > attribute automatically when a filesystem is mounted on a USB device.
> > When that time comes this patch can be reverted, if people think it
> > matters.
> ..
> 
> Should the next word below be "that", rather than "this" ?

Yours is a rather obscure grammatical question, especially concerning a
Changelog entry (which is not even as significant to developers as a
comment, IMO).  What difference in meaning do you imagine replacing
"This" with "That" would achieve?

> > This approach has the advantage of giving the user the ability to turn
> > off USB-PERSIST for devices with mounted filesystems, rather than
> > making the kernel always assume it should be on.
> ...

What I meant (it probably wasn't very clear from the text) was that the
approach of leaving USB-PERSIST controlled by the power/persist
attribute and merely altering the attribute's default value is better
than having the kernel unilaterally and unconditionally turn
USB-PERSIST on for every device holding a mounted filesystem.  In other
words, the approach taken by the patch is better than the approach
suggested by Linus Torvalds.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/