linux-kernel - Re: [PATCH] Audit: netlink socket can be auto-bound to pid other than current->pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e0fb38c0803181635t7b629bc4x707e4083b1c81edf@mail.gmail.com>
Date:	Tue, 18 Mar 2008 19:35:08 -0400
From:	"Eric Paris" <eparis@...isplace.org>
To:	"Pavel Emelyanov" <xemul@...nvz.org>
Cc:	linux-audit@...hat.com, "Thomas Graf" <tgraf@...g.ch>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	aviro@...hat.com, sgrubb@...hat.com, akpm@...l.org
Subject: Re: [PATCH] Audit: netlink socket can be auto-bound to pid other than current->pid

On 3/18/08, Eric Paris <eparis@...isplace.org> wrote:
> On 3/18/08, Pavel Emelyanov <xemul@...nvz.org> wrote:

>  >  @@ -626,6 +628,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  >                                                         sid, 1);
>  >
>  >                         audit_pid = new_pid;
>  >  +                       audit_nlk_pid = NETLINK_CB(skb).pid;
>  >                 }
>  >                 if (status_get->mask & AUDIT_STATUS_RATE_LIMIT)
>  >                         err = audit_set_rate_limit(status_get->rate_limit,

Shouldn't the above be:

if (audit_pid)
    audit_nlk_pid = NETLINK_CB(skb).pid;
else
   audit_nlk_pid = 0;

otherwise I don't see how you can cleanly stop the userspace auditd.....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/